diff options
| author | Michael Niedermayer <michaelni@gmx.at> | 2013-09-21 23:34:11 +0200 |
|---|---|---|
| committer | Michael Niedermayer <michaelni@gmx.at> | 2013-09-22 00:04:39 +0200 |
| commit | e07ac727c1cc9eed39e7f9117c97006f719864bd (patch) | |
| tree | cee41cdfc73678ba12cbeee78436d42ec0050625 | |
| parent | 5dca837ac39a435fa3ff1a10eb5486dbc22be0c5 (diff) | |
| download | ffmpeg-e07ac727c1cc9eed39e7f9117c97006f719864bd.tar.gz | |
avcodec/g2meet: Fix framebuf size
Currently the code can in some cases draw tiles that hang outside the
allocated buffer. This patch increases the buffer size to avoid out
of array accesses. An alternative would be to fail if such tiles are
encountered.
I do not know if any valid files use such hanging tiles.
Fixes Ticket2971
Found-by: ami_stuff
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
| -rw-r--r-- | libavcodec/g2meet.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/libavcodec/g2meet.c b/libavcodec/g2meet.c index ccccf21834..1eae1a49b5 100644 --- a/libavcodec/g2meet.c +++ b/libavcodec/g2meet.c @@ -443,8 +443,8 @@ static int g2m_init_buffers(G2MContext *c) int aligned_height; if (!c->framebuf || c->old_width < c->width || c->old_height < c->height) { - c->framebuf_stride = FFALIGN(c->width * 3, 16); - aligned_height = FFALIGN(c->height, 16); + c->framebuf_stride = FFALIGN(c->width + 15, 16) * 3; + aligned_height = c->height + 15; av_free(c->framebuf); c->framebuf = av_mallocz(c->framebuf_stride * aligned_height); if (!c->framebuf) |