diff options
| author | Michael Niedermayer <michaelni@gmx.at> | 2013-08-20 23:18:48 +0200 |
|---|---|---|
| committer | Michael Niedermayer <michaelni@gmx.at> | 2013-08-29 02:13:25 +0200 |
| commit | deb8d0d6a121a155b5e396ea5b8da5567ac263f0 (patch) | |
| tree | 4c6eaee982f12b7dac58f8156bc0c1ed0cd34b9b | |
| parent | 3e817d91ef6b8b1681b4d4e5e4bdbd54a720e3de (diff) | |
| download | ffmpeg-deb8d0d6a121a155b5e396ea5b8da5567ac263f0.tar.gz | |
avcodec/flashsv: check diff_start/height
Fixes out of array accesses
Fixes Ticket2844
Found-by: ami_stuff
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
(cherry picked from commit 880c73cd76109697447fbfbaa8e5ee5683309446)
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
| -rw-r--r-- | libavcodec/flashsv.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/libavcodec/flashsv.c b/libavcodec/flashsv.c index 9982b5e966..f00bf21d47 100644 --- a/libavcodec/flashsv.c +++ b/libavcodec/flashsv.c @@ -387,6 +387,10 @@ static int flashsv_decode_frame(AVCodecContext *avctx, void *data, } s->diff_start = get_bits(&gb, 8); s->diff_height = get_bits(&gb, 8); + if (s->diff_start + s->diff_height > cur_blk_height) { + av_log(avctx, AV_LOG_ERROR, "Block parameters invalid\n"); + return AVERROR_INVALIDDATA; + } av_log(avctx, AV_LOG_DEBUG, "%dx%d diff start %d height %d\n", i, j, s->diff_start, s->diff_height); |