aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Niedermayer <michael@niedermayer.cc>2017-09-05 00:16:29 +0200
committerMichael Niedermayer <michael@niedermayer.cc>2018-01-31 22:56:14 +0100
commitdc4ef664ab385e4e1d44746c811a37445f3dedbe (patch)
treec31cbcb412198bf93e3cd311ccf0a9adfc39ad3d
parent812e06cc829674537bab7a89f664dda70edaf188 (diff)
downloadffmpeg-dc4ef664ab385e4e1d44746c811a37445f3dedbe.tar.gz
avformat/mov: Fix DoS in read_tfra()
Fixes: Missing EOF check in loop No testcase Found-by: Xiaohei and Wangchu from Alibaba Security Team Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 9cb4eb772839c5e1de2855d126bf74ff16d13382) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
-rw-r--r--libavformat/mov.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/libavformat/mov.c b/libavformat/mov.c
index 478b50b5b2..0ff3c1cd48 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -4408,6 +4408,13 @@ static int read_tfra(MOVContext *mov, AVIOContext *f)
}
for (i = 0; i < index->item_count; i++) {
int64_t time, offset;
+
+ if (avio_feof(f)) {
+ index->item_count = 0;
+ av_freep(&index->items);
+ return AVERROR_INVALIDDATA;
+ }
+
if (version == 1) {
time = avio_rb64(f);
offset = avio_rb64(f);