diff options
| author | Michael Niedermayer <michaelni@gmx.at> | 2012-01-24 17:48:23 +0100 |
|---|---|---|
| committer | Alex Converse <alex.converse@gmail.com> | 2012-03-06 15:28:00 -0800 |
| commit | d7fddc97d40025876e1342109a49f07ba8fa6878 (patch) | |
| tree | e8a6ffc8e9f95747e1507a2a353a0e1632b02440 | |
| parent | feed0c6b6ae31cb3d5af144c74dd2040051780b7 (diff) | |
| download | ffmpeg-d7fddc97d40025876e1342109a49f07ba8fa6878.tar.gz | |
dv: check stype
dv: check stype
Fixes part1 of CVE-2011-3929
Possibly fixes part of CVE-2011-3936
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Reviewed-by: Roman Shaposhnik <roman@shaposhnik.org>
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Alex Converse <alex.converse@gmail.com>
(cherry picked from commit 635bcfccd439480003b74a665b5aa7c872c1ad6b)
| -rw-r--r-- | libavformat/dv.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/libavformat/dv.c b/libavformat/dv.c index 805f25271c..4896b0a3fe 100644 --- a/libavformat/dv.c +++ b/libavformat/dv.c @@ -204,6 +204,12 @@ static int dv_extract_audio_info(DVDemuxContext* c, uint8_t* frame) stype = (as_pack[3] & 0x1f); /* 0 - 2CH, 2 - 4CH, 3 - 8CH */ quant = as_pack[4] & 0x07; /* 0 - 16bit linear, 1 - 12bit nonlinear */ + if (stype > 3) { + av_log(c->fctx, AV_LOG_ERROR, "stype %d is invalid\n", stype); + c->ach = 0; + return 0; + } + /* note: ach counts PAIRS of channels (i.e. stereo channels) */ ach = ((int[4]){ 1, 0, 2, 4})[stype]; if (ach == 1 && quant && freq == 2) |