diff options
| author | Michael Niedermayer <michael@niedermayer.cc> | 2016-10-25 03:51:17 +0200 |
|---|---|---|
| committer | Michael Niedermayer <michael@niedermayer.cc> | 2016-12-04 20:25:15 +0100 |
| commit | d54aa2de176119f49d3491be8b8fe7ad7848577f (patch) | |
| tree | 95edb1795f508b1558072e551c4630e8e6538854 | |
| parent | bab7d72d46458061065a41536611793b9a53fa5a (diff) | |
| download | ffmpeg-d54aa2de176119f49d3491be8b8fe7ad7848577f.tar.gz | |
avcodec/interplayvideo: Check side data size before use
Fixes out of array read
Found-by: Thomas Garnier using libFuzzer
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 85d23e5cbc9ad6835eef870a5b4247de78febe56)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
| -rw-r--r-- | libavcodec/interplayvideo.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/libavcodec/interplayvideo.c b/libavcodec/interplayvideo.c index 1460741a53..3c3212e1fe 100644 --- a/libavcodec/interplayvideo.c +++ b/libavcodec/interplayvideo.c @@ -1012,10 +1012,13 @@ static int ipvideo_decode_frame(AVCodecContext *avctx, return ret; if (!s->is_16bpp) { - const uint8_t *pal = av_packet_get_side_data(avpkt, AV_PKT_DATA_PALETTE, NULL); - if (pal) { + int size; + const uint8_t *pal = av_packet_get_side_data(avpkt, AV_PKT_DATA_PALETTE, &size); + if (pal && size == AVPALETTE_SIZE) { frame->palette_has_changed = 1; memcpy(s->pal, pal, AVPALETTE_SIZE); + } else if (pal) { + av_log(avctx, AV_LOG_ERROR, "Palette size %d is wrong\n", size); } } |