aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Niedermayer <michael@niedermayer.cc>2016-08-20 19:21:07 +0200
committerMichael Niedermayer <michael@niedermayer.cc>2017-08-23 13:15:16 +0200
commitd28e753895cad82f44f91941b340fec4f0a92e3f (patch)
treec8d0d99678f61cb16c24de38290538561af26350
parent4d94486e7ee898c0f7631e6ec44dd9f4e37892f6 (diff)
downloadffmpeg-d28e753895cad82f44f91941b340fec4f0a92e3f.tar.gz
avcodec/diracdec: Check numx/y
Fixes division by 0 Fixes: 60261c4469ba3e11059890fb2832a515/asan_generic_135e694_2790_beb94eaa0aeb7d11c0437375a8964a99.drc Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit a31e08fa1aa5c5f0518b8af850f28eb945268e66) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
-rw-r--r--libavcodec/diracdec.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/libavcodec/diracdec.c b/libavcodec/diracdec.c
index 6b93d8632b..eaaf9f7720 100644
--- a/libavcodec/diracdec.c
+++ b/libavcodec/diracdec.c
@@ -1028,6 +1028,13 @@ static int dirac_unpack_idwt_params(DiracContext *s)
/*[DIRAC_STD] 11.3.4 Slice coding Parameters (low delay syntax only). slice_parameters() */
s->lowdelay.num_x = svq3_get_ue_golomb(gb);
s->lowdelay.num_y = svq3_get_ue_golomb(gb);
+ if (s->lowdelay.num_x * s->lowdelay.num_y == 0 ||
+ s->lowdelay.num_x * (uint64_t)s->lowdelay.num_y > INT_MAX) {
+ av_log(s->avctx,AV_LOG_ERROR,"Invalid numx/y\n");
+ s->lowdelay.num_x = s->lowdelay.num_y = 0;
+ return AVERROR_INVALIDDATA;
+ }
+
s->lowdelay.bytes.num = svq3_get_ue_golomb(gb);
s->lowdelay.bytes.den = svq3_get_ue_golomb(gb);