diff options
| author | James Almer <jamrial@gmail.com> | 2017-09-25 17:17:12 -0300 |
|---|---|---|
| committer | James Almer <jamrial@gmail.com> | 2017-10-01 19:19:22 -0300 |
| commit | cf3d2d52b59ddfc2a7c65a8e66f7698c4b837e51 (patch) | |
| tree | d21e30b0deef824909fa2230c12905d2ff1eddae | |
| parent | fd5f4ac0813c27c34c387f00044905a859e29e37 (diff) | |
| download | ffmpeg-cf3d2d52b59ddfc2a7c65a8e66f7698c4b837e51.tar.gz | |
avcodec/avpacket: deprecate av_copy_packet_side_data()
It leaks memory and destroys the dst packet in case of failure, and it
ultimately duplicates functionality already existing in the saner
av_packet_copy_props().
Reviewed-by: wm4
Signed-off-by: James Almer <jamrial@gmail.com>
| -rw-r--r-- | libavcodec/avcodec.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index dd7c4b4ce5..52cc5b0ca0 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -4632,7 +4632,10 @@ int av_copy_packet(AVPacket *dst, const AVPacket *src); * Copy packet side data * * @return 0 on success, negative AVERROR on fail + * + * @deprecated Use av_packet_copy_props */ +attribute_deprecated int av_copy_packet_side_data(AVPacket *dst, const AVPacket *src); /** |