diff options
| author | Rémi Denis-Courmont <remi@remlab.net> | 2023-12-17 17:14:05 +0200 |
|---|---|---|
| committer | Rémi Denis-Courmont <remi@remlab.net> | 2023-12-21 17:54:23 +0200 |
| commit | cdd38a2ffe9a6a092b5aee34cc5fe7fe20b72148 (patch) | |
| tree | 2544dab9d68eb1358d6bfc741995a7c6cda9c39d | |
| parent | db32f75c635c5783b76e7c3fd8060548d0917180 (diff) | |
| download | ffmpeg-cdd38a2ffe9a6a092b5aee34cc5fe7fe20b72148.tar.gz | |
lavc/aacpsdsp: fix R-V V stereo interpolate
The penultimate loop iteration could pick any vl such that:
vlenb/4 < vl <= vlenb/2
Thus if the total length is not a multiple of vlenb/2, the vfadd.vf
on the penultimate iteration would yield corrupt values for the last
iteration.
To avoid this, force vl = vlen/2 until the last iteration. Unfortunately
this latent bug is not reproducible with either hardware or QEMU as of now.
| -rw-r--r-- | libavcodec/riscv/aacpsdsp_rvv.S | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/libavcodec/riscv/aacpsdsp_rvv.S b/libavcodec/riscv/aacpsdsp_rvv.S index f46b35fe91..a79d7d7818 100644 --- a/libavcodec/riscv/aacpsdsp_rvv.S +++ b/libavcodec/riscv/aacpsdsp_rvv.S @@ -234,7 +234,8 @@ func ff_ps_stereo_interpolate_rvv, zve32f vfmacc.vf v22, ft3, v24 fmul.s ft3, ft3, ft4 1: - vsetvli t0, a4, e32, m2, ta, ma + min t0, t0, a4 + vsetvli zero, t0, e32, m2, ta, ma vlseg2e32.v v0, (a0) // v0:l_re, v2:l_im sub a4, a4, t0 vlseg2e32.v v4, (a1) // v4:r_re, v6:r_im |