diff options
| author | Michael Niedermayer <[email protected]> | 2020-02-22 00:42:30 +0100 |
|---|---|---|
| committer | Michael Niedermayer <[email protected]> | 2020-05-19 17:17:35 +0200 |
| commit | c80bb322a8581fbee71620218c9c29e32da96f22 (patch) | |
| tree | 02ec6d79235f13f0f5d8e72a91e5592a1179c246 | |
| parent | 07ffedc01de88963f9273fa4f3662aba2d99dbed (diff) | |
avcodec/magicyuv: Check that there are enough lines for interlacing to be possible
Fixes: out of array access
Fixes: 20763/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MAGICYUV_fuzzer-5759562508664832
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Reviewed-by: Paul B Mahol <[email protected]>
Signed-off-by: Michael Niedermayer <[email protected]>
(cherry picked from commit f8a0e9f9f71cf5650bdc250ff7475e0f7d8e8420)
Signed-off-by: Michael Niedermayer <[email protected]>
| -rw-r--r-- | libavcodec/magicyuv.c | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/libavcodec/magicyuv.c b/libavcodec/magicyuv.c index f4fb2a7809..c1dd9de68c 100644 --- a/libavcodec/magicyuv.c +++ b/libavcodec/magicyuv.c @@ -677,6 +677,17 @@ static int magy_decode_frame(AVCodecContext *avctx, void *data, return AVERROR_INVALIDDATA; } + if (s->interlaced) { + if ((s->slice_height >> s->vshift[1]) < 2) { + av_log(avctx, AV_LOG_ERROR, "impossible slice height\n"); + return AVERROR_INVALIDDATA; + } + if ((avctx->coded_height % s->slice_height) && ((avctx->coded_height % s->slice_height) >> s->vshift[1]) < 2) { + av_log(avctx, AV_LOG_ERROR, "impossible height\n"); + return AVERROR_INVALIDDATA; + } + } + for (i = 0; i < s->planes; i++) { av_fast_malloc(&s->slices[i], &s->slices_size[i], s->nb_slices * sizeof(Slice)); if (!s->slices[i]) |