aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Niedermayer <michael@niedermayer.cc>2017-05-24 19:40:42 +0200
committerMichael Niedermayer <michael@niedermayer.cc>2017-05-25 11:30:56 +0200
commitc071e74aad6a13b46fa8b2d66f5d6d9a6d4beae0 (patch)
tree900d67e23051fd23dfe8134eb6ab0d50f4b14fcd
parent5753c06dd79fcd1e49db87407784921c35810950 (diff)
downloadffmpeg-c071e74aad6a13b46fa8b2d66f5d6d9a6d4beae0.tar.gz
avcodec/jpeg2000dec: Check tile offsets
Fixes: runtime error: signed integer overflow: 4096 - -2147483648 cannot be represented in type 'int' Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 89325417e7b33f4b08171d9d609c48662d96b2d3) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
-rw-r--r--libavcodec/jpeg2000dec.c8
1 files changed, 8 insertions, 0 deletions
diff --git a/libavcodec/jpeg2000dec.c b/libavcodec/jpeg2000dec.c
index c13670e6d6..b2e1713c65 100644
--- a/libavcodec/jpeg2000dec.c
+++ b/libavcodec/jpeg2000dec.c
@@ -298,6 +298,14 @@ static int get_siz(Jpeg2000DecoderContext *s)
return AVERROR_PATCHWELCOME;
}
+ if (s->tile_offset_x < 0 || s->tile_offset_y < 0 ||
+ s->image_offset_x < s->tile_offset_x ||
+ s->image_offset_y < s->tile_offset_y) {
+ av_log(s->avctx, AV_LOG_ERROR, "Tile offsets are invalid\n",
+ s->ncomponents);
+ return AVERROR_INVALIDDATA;
+ }
+
s->ncomponents = ncomponents;
if (s->tile_width <= 0 || s->tile_height <= 0) {