diff options
| author | Andreas Rheinhardt <andreas.rheinhardt@gmail.com> | 2020-05-24 03:14:00 +0200 |
|---|---|---|
| committer | Andreas Rheinhardt <andreas.rheinhardt@gmail.com> | 2020-07-03 13:48:05 +0200 |
| commit | b9b845e98a6692ce85d7cfd51a8717817ee309a1 (patch) | |
| tree | 071c5c64cdd28ee2700093408ef416863a51f8b9 | |
| parent | 7b80a7e498286a7aaf1e58f66783ea367f49849c (diff) | |
| download | ffmpeg-b9b845e98a6692ce85d7cfd51a8717817ee309a1.tar.gz | |
avformat/aviobuf: Don't check for overflow after it happened
If adding two ints overflows, it doesn't matter whether the result will
be stored in an unsigned or not; and checking afterwards does not make it
retroactively defined.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
(cherry picked from commit 28a078eded1c29985ed078b59d48ff59cf00394b)
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
| -rw-r--r-- | libavformat/aviobuf.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c index 9afe9b3a68..c4687a7d89 100644 --- a/libavformat/aviobuf.c +++ b/libavformat/aviobuf.c @@ -1209,7 +1209,7 @@ static int dyn_buf_write(void *opaque, uint8_t *buf, int buf_size) unsigned new_size, new_allocated_size; /* reallocate buffer if needed */ - new_size = d->pos + buf_size; + new_size = (unsigned)d->pos + buf_size; new_allocated_size = d->allocated_size; if (new_size < d->pos || new_size > INT_MAX/2) return -1; |