diff options
| author | Michael Niedermayer <[email protected]> | 2017-11-13 20:47:48 +0100 |
|---|---|---|
| committer | Michael Niedermayer <[email protected]> | 2018-01-08 23:19:14 +0100 |
| commit | b51f515c5c837351f2104b43c0e2a0562a759086 (patch) | |
| tree | fe16a0d09586ea070ef95f04ac1358e528084115 | |
| parent | 4654cc8cee07b7772239eec7d263d6cd9c6a4f0d (diff) | |
avcodec/x86/mpegvideodsp: Fix signedness bug in need_emu
Fixes: out of array read
Fixes: 3516/attachment-311488.dat
Found-by: Insu Yun, Georgia Tech.
Tested-by: [email protected]
Signed-off-by: Michael Niedermayer <[email protected]>
(cherry picked from commit 58cf31cee7a456057f337b3102a03206d833d5e8)
Signed-off-by: Michael Niedermayer <[email protected]>
| -rw-r--r-- | libavcodec/x86/mpegvideodsp.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/libavcodec/x86/mpegvideodsp.c b/libavcodec/x86/mpegvideodsp.c index e0498f3849..6009b64e07 100644 --- a/libavcodec/x86/mpegvideodsp.c +++ b/libavcodec/x86/mpegvideodsp.c @@ -52,8 +52,9 @@ static void gmc_mmx(uint8_t *dst, uint8_t *src, const int dyh = (dyy - (1 << (16 + shift))) * (h - 1); const int dxh = dxy * (h - 1); const int dyw = dyx * (w - 1); - int need_emu = (unsigned) ix >= width - w || - (unsigned) iy >= height - h; + int need_emu = (unsigned) ix >= width - w || width < w || + (unsigned) iy >= height - h || height< h + ; if ( // non-constant fullpel offset (3% of blocks) ((ox ^ (ox + dxw)) | (ox ^ (ox + dxh)) | (ox ^ (ox + dxw + dxh)) | |