aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Niedermayer <michaelni@gmx.at>2014-03-03 17:04:57 +0100
committerMichael Niedermayer <michaelni@gmx.at>2014-03-03 17:04:57 +0100
commitab5d46df1656a23cb75b005a3d7730e189e38c4d (patch)
tree26dd1bf8828643cf21cc8050a379216647fdfac4
parent65c95de213d9fcf3f06513bcb9ce6ed5396fa75d (diff)
downloadffmpeg-ab5d46df1656a23cb75b005a3d7730e189e38c4d.tar.gz
avformat/httpauth: add comment about "" and algorithm
Suggested-by: ubitux Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
-rw-r--r--libavformat/httpauth.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/libavformat/httpauth.c b/libavformat/httpauth.c
index 3f90975ff3..dbe3eff48f 100644
--- a/libavformat/httpauth.c
+++ b/libavformat/httpauth.c
@@ -224,8 +224,11 @@ static char *make_digest_auth(HTTPAuthState *state, const char *username,
av_strlcatf(authstr, len, ",nonce=\"%s\"", digest->nonce);
av_strlcatf(authstr, len, ",uri=\"%s\"", uri);
av_strlcatf(authstr, len, ",response=\"%s\"", response);
+
+ // we are violating the RFC and use "" because all others seem to do that too.
if (digest->algorithm[0])
av_strlcatf(authstr, len, ",algorithm=\"%s\"", digest->algorithm);
+
if (digest->opaque[0])
av_strlcatf(authstr, len, ",opaque=\"%s\"", digest->opaque);
if (digest->qop[0]) {