diff options
| author | winlin <winlinvip@gmail.com> | 2025-06-10 14:53:08 -0400 |
|---|---|---|
| committer | Kacper Michajłow <kasper93@gmail.com> | 2025-08-10 02:26:16 +0000 |
| commit | a72cc49e8a08dd61cbcf61cac664601c70bc9517 (patch) | |
| tree | ee0924fc68aa78a22c4d199945ab7f2a90b1f1de | |
| parent | 49f4ef9e79e733c0210420708f100f1a6ed93d7f (diff) | |
| download | ffmpeg-a72cc49e8a08dd61cbcf61cac664601c70bc9517.tar.gz | |
avformat/tls_openssl: fix X509 cert serial number might be negative
See RFC5280 4.1.2.2
Signed-off-by: Jack Lau <jacklau1222@qq.com>
| -rw-r--r-- | libavformat/tls_openssl.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 65b2966688..bab2e711c6 100644 --- a/libavformat/tls_openssl.c +++ b/libavformat/tls_openssl.c @@ -315,7 +315,8 @@ end: static int openssl_gen_certificate(EVP_PKEY *pkey, X509 **cert, char **fingerprint) { - int ret = 0, serial, expire_day; + int ret = 0, expire_day; + uint64_t serial; const char *aor = "lavf"; X509_NAME* subject = NULL; @@ -330,8 +331,8 @@ static int openssl_gen_certificate(EVP_PKEY *pkey, X509 **cert, char **fingerpri goto enomem_end; } - serial = (int)av_get_random_seed(); - if (ASN1_INTEGER_set(X509_get_serialNumber(*cert), serial) != 1) { + serial = av_get_random_seed(); + if (ASN1_INTEGER_set_uint64(X509_get_serialNumber(*cert), serial) != 1) { av_log(NULL, AV_LOG_ERROR, "TLS: Failed to set serial, %s\n", ERR_error_string(ERR_get_error(), NULL)); goto einval_end; } |