diff options
| author | Michael Niedermayer <michaelni@gmx.at> | 2014-11-25 14:45:30 +0100 |
|---|---|---|
| committer | Michael Niedermayer <michaelni@gmx.at> | 2014-12-02 00:26:19 +0100 |
| commit | a65573c45d346a7d5aa197362af368caf1a1b56c (patch) | |
| tree | ec8acc5a842e282e7d86736ca1232a7c8b910723 | |
| parent | 6c28673cb3648d49117c6bfa4ed89ead157b1c22 (diff) | |
| download | ffmpeg-a65573c45d346a7d5aa197362af368caf1a1b56c.tar.gz | |
avcodec/utils: Check that the data is complete in avpriv_bprint_to_extradata()
Fixes out of array read
Fixes: asan_heap-oob_4d2250_814_cov_2745172097_JACOsub_capability_tester.jss
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
(cherry picked from commit 3d5d95db3f5d8e2093e9e19d0c46e86f54ed2a5d)
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
| -rw-r--r-- | libavcodec/utils.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/libavcodec/utils.c b/libavcodec/utils.c index 7cceafa3a4..87184098e9 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -2876,6 +2876,11 @@ int avpriv_bprint_to_extradata(AVCodecContext *avctx, struct AVBPrint *buf) ret = av_bprint_finalize(buf, &str); if (ret < 0) return ret; + if (!av_bprint_is_complete(buf)) { + av_free(str); + return AVERROR(ENOMEM); + } + avctx->extradata = str; /* Note: the string is NUL terminated (so extradata can be read as a * string), but the ending character is not accounted in the size (in |