Merge commit 'b8cd7a3c8df2c3aac8d7a0b5a02d83caf61bd769'

* commit 'b8cd7a3c8df2c3aac8d7a0b5a02d83caf61bd769':
  dvbsub: Check for errors from system()

printf(...) replaced with fprintf(stderr, ...) for logging errors.

Merged-by: Clément Bœsch <u@pkh.me>

1 files changed, 8 insertions, 2 deletions

diff --git a/libavcodec/dvbsubdec.c b/libavcodec/dvbsubdec.c
index 7c27d69ce2..26985dd9d1 100644
--- a/libavcodec/dvbsubdec.c
+++ b/libavcodec/dvbsubdec.c
@@ -85,10 +85,16 @@ static void png_save(const char *filename, uint32_t *bitmap, int w, int h)
     fclose(f);
 
     snprintf(command, sizeof(command), "pnmtopng -alpha %s %s > %s.png 2> /dev/null", fname2, fname, filename);
-    system(command);
+    if (system(command) != 0) {
+        fprintf(stderr, "Error running pnmtopng\n");
+        return;
+    }
 
     snprintf(command, sizeof(command), "rm %s %s", fname, fname2);
-    system(command);
+    if (system(command) != 0) {
+        fprintf(stderr, "Error removing %s and %s\n", fname, fname2);
+        return;
+    }
 }
 #endif