diff options
| author | Stefan Huehner <stefan@huehner.org> | 2006-02-09 14:08:03 +0000 |
|---|---|---|
| committer | Dominik Mierzejewski <dominik@rangers.eu.org> | 2006-02-09 14:08:03 +0000 |
| commit | 9b2283cc3352b1f446814f0c6fa5230978b9ee78 (patch) | |
| tree | 7365b76be8f96fbcadd166e72518e017f6b341ef | |
| parent | ee7388c934a89aecce919d17bc28773822e2b444 (diff) | |
| download | ffmpeg-9b2283cc3352b1f446814f0c6fa5230978b9ee78.tar.gz | |
Patch by Stefan Huehner / stefan % huehner ! org \
patch replaces '()' for the correct '(void)' in function
declarations/prototypes which have no parameters. The '()' syntax tell
thats there is a variable list of arguments, so that the compiler cannot
check this. The extra CFLAG '-Wstrict-declarations' shows those cases.
Comments about a similar patch applied to ffmpeg:
That in C++ these mean the same, but in ANSI C the semantics are
different; function() is an (obsolete) K&R C style forward declaration,
it basically means that the function can have any number and any types
of parameters, effectively completely preventing the compiler from doing
any sort of type checking. -- Erik Slagter
Defining functions with unspecified arguments is allowed but bad.
With arguments unspecified the compiler can't report an error/warning
if the function is called with incorrect arguments. -- Måns Rullgård
Originally committed as revision 17567 to svn://svn.mplayerhq.hu/mplayer/trunk/postproc
| -rw-r--r-- | postproc/swscale.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/postproc/swscale.c b/postproc/swscale.c index 2b0d585b1a..e4537f7bf2 100644 --- a/postproc/swscale.c +++ b/postproc/swscale.c @@ -1375,7 +1375,7 @@ static void initMMX2HScaler(int dstW, int xInc, uint8_t *funnyCode, int16_t *fil } #endif // ARCH_X86 || ARCH_X86_64 -static void globalInit(){ +static void globalInit(void){ // generating tables: int i; for(i=0; i<768; i++){ |