diff options
| author | Michael Niedermayer <michael@niedermayer.cc> | 2016-10-30 15:12:12 +0100 |
|---|---|---|
| committer | Michael Niedermayer <michael@niedermayer.cc> | 2016-10-31 23:20:47 +0100 |
| commit | 979bca513424879ed0c653cb1b55fc4156a89576 (patch) | |
| tree | 7fa82c2d9c510bbb9d8b586440666d80ceabf17c | |
| parent | e167610794db8f2202f9dbe013c54f6b34d7f7a0 (diff) | |
| download | ffmpeg-979bca513424879ed0c653cb1b55fc4156a89576.tar.gz | |
avcodec/tscc: Check side data size before use
Fixes out of array read
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
| -rw-r--r-- | libavcodec/tscc.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/libavcodec/tscc.c b/libavcodec/tscc.c index bd5fe035cf..cb86b584c1 100644 --- a/libavcodec/tscc.c +++ b/libavcodec/tscc.c @@ -98,11 +98,14 @@ static int decode_frame(AVCodecContext *avctx, void *data, int *got_frame, /* make the palette available on the way out */ if (c->avctx->pix_fmt == AV_PIX_FMT_PAL8) { - const uint8_t *pal = av_packet_get_side_data(avpkt, AV_PKT_DATA_PALETTE, NULL); + int size; + const uint8_t *pal = av_packet_get_side_data(avpkt, AV_PKT_DATA_PALETTE, &size); - if (pal) { + if (pal && size == AVPALETTE_SIZE) { frame->palette_has_changed = 1; memcpy(c->pal, pal, AVPALETTE_SIZE); + } else if (pal) { + av_log(avctx, AV_LOG_ERROR, "Palette size %d is wrong\n", size); } memcpy(frame->data[1], c->pal, AVPALETTE_SIZE); } |