aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>2016-01-04 12:53:20 +0100
committerAndreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>2016-01-28 01:21:07 +0100
commit95e52303da7e0f795fbee26714f83f8f895ffc1a (patch)
tree1a9f4526144cb09454af76e57ae27bb9f76fa805
parent20d4c087ed8c55ceab48814bd715983f88b411c3 (diff)
downloadffmpeg-95e52303da7e0f795fbee26714f83f8f895ffc1a.tar.gz
brstm: also allocate b->table in read_packet
This fixes NULL pointer dereferencing if the codec is forced to adpcm_thp even though a different one was detected. Reviewed-by: Paul B Mahol <onemda@gmail.com> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com> (cherry picked from commit bcf4ee26a0a1ed349ec7489925540401002b87cc) Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
-rw-r--r--libavformat/brstm.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/libavformat/brstm.c b/libavformat/brstm.c
index 9228fa7488..aba3770ee6 100644
--- a/libavformat/brstm.c
+++ b/libavformat/brstm.c
@@ -263,6 +263,10 @@ static int read_packet(AVFormatContext *s, AVPacket *pkt)
if (!b->adpc) {
av_log(s, AV_LOG_ERROR, "adpcm_thp requires ADPC chunk, but none was found.\n");
return AVERROR_INVALIDDATA;
+ if (!b->table) {
+ b->table = av_mallocz(32 * codec->channels);
+ if (!b->table)
+ return AVERROR(ENOMEM);
}
if (av_new_packet(pkt, 8 + (32 + 4) * codec->channels + size) < 0)