aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPeter Ross <pross@xvid.org>2022-11-01 10:16:43 +1100
committerPeter Ross <pross@xvid.org>2022-11-02 18:39:39 +1100
commit95386b7b65dab6fb72bf76c14470904782642ebc (patch)
tree8c44cde2480c907fc2bed94b8c96ac3f5e4153d9
parent12733c0cbd49077d3aac48007f674f14d1e15ccd (diff)
downloadffmpeg-95386b7b65dab6fb72bf76c14470904782642ebc.tar.gz
avcodec/svq3: perform residual slice copy before xor'ing watermark key
Fixes ticket #5387
-rw-r--r--libavcodec/svq3.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/libavcodec/svq3.c b/libavcodec/svq3.c
index 7e8f16cc72..b96c4f61f6 100644
--- a/libavcodec/svq3.c
+++ b/libavcodec/svq3.c
@@ -1037,15 +1037,16 @@ static int svq3_decode_slice_header(AVCodecContext *avctx)
}
memcpy(s->slice_buf, s->gb.buffer + s->gb.index / 8, slice_bytes);
+ if (length > 0) {
+ memmove(s->slice_buf, &s->slice_buf[slice_length], length - 1);
+ }
+
if (s->watermark_key) {
uint32_t header = AV_RL32(&s->slice_buf[1]);
AV_WL32(&s->slice_buf[1], header ^ s->watermark_key);
}
init_get_bits(&s->gb_slice, s->slice_buf, slice_bits);
- if (length > 0) {
- memmove(s->slice_buf, &s->slice_buf[slice_length], length - 1);
- }
skip_bits_long(&s->gb, slice_bytes * 8);
}