aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorwm4 <nfxjfg@googlemail.com>2015-09-30 14:53:35 +0200
committerCarl Eugen Hoyos <cehoyos@ag.or.at>2015-10-09 21:56:00 +0200
commit9177bcc06ca5fa583608b5a6d77c6d2bebe9def6 (patch)
tree799adeb089d6ef25f95a92475c8e5c6614bdc9f5
parentf2c07de0a5a7ea1c48fc872f1057974cf0df3ca7 (diff)
downloadffmpeg-9177bcc06ca5fa583608b5a6d77c6d2bebe9def6.tar.gz
avcodec/mp3: fix skipping zeros
Commits 43bc5cf9 and c5371f77 add code for skipping initial zeros in mp3 packets. This code forgot to report to the user that data was skipped at all. Since audio codecs allow partial packet decoding, the user application has to rely on the return value. It will remove the data reported as consumed by the decoder, and feed it to the decoder again. This resulted in the mp3 frame after the zero region to be decoded over and over again, until the zero region was finally skipped by the application. Fix this by including the amount of skipped bytes to the number of consumed bytes returned by the decode call. Fixes trac ticket #4890. (cherry picked from commit cb1da9fb8d71bb611a7b0028914c97afc3f5711d)
-rw-r--r--libavcodec/mpegaudiodec_template.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/libavcodec/mpegaudiodec_template.c b/libavcodec/mpegaudiodec_template.c
index 0aa14b7463..dcbde7c6aa 100644
--- a/libavcodec/mpegaudiodec_template.c
+++ b/libavcodec/mpegaudiodec_template.c
@@ -1657,9 +1657,11 @@ static int decode_frame(AVCodecContext * avctx, void *data, int *got_frame_ptr,
uint32_t header;
int ret;
+ int skipped = 0;
while(buf_size && !*buf){
buf++;
buf_size--;
+ skipped++;
}
if (buf_size < HEADER_SIZE)
@@ -1714,7 +1716,7 @@ static int decode_frame(AVCodecContext * avctx, void *data, int *got_frame_ptr,
return ret;
}
s->frame_size = 0;
- return buf_size;
+ return buf_size + skipped;
}
static void mp_flush(MPADecodeContext *ctx)