diff options
| author | Michael Niedermayer <michael@niedermayer.cc> | 2019-10-11 00:40:07 +0200 |
|---|---|---|
| committer | Michael Niedermayer <michael@niedermayer.cc> | 2019-12-06 20:30:57 +0100 |
| commit | 8b462c958a91146185f3ba757ac9b839086de5bc (patch) | |
| tree | d862e97d61e6744fe57db2f45c463c80420ceb76 | |
| parent | 68a8bdf5f1985fa6b0d952bbba82374b4e1f9e8f (diff) | |
| download | ffmpeg-8b462c958a91146185f3ba757ac9b839086de5bc.tar.gz | |
avcodec/binkaudio: Check sample rate
Fixes: signed integer overflow: 1092624416 * 2 cannot be represented in type 'int'
Fixes: 18045/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BINKAUDIO_RDFT_fuzzer-5718519492116480
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Reviewed-by: Paul B Mahol <onemda@gmail.com>
Reviewed-by: Peter Ross <pross@xvid.org>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 2fca09bce49c7de590560d9517fd2414b6c0c14f)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
| -rw-r--r-- | libavcodec/binkaudio.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/libavcodec/binkaudio.c b/libavcodec/binkaudio.c index 5cc23311f5..e1c96aa1b1 100644 --- a/libavcodec/binkaudio.c +++ b/libavcodec/binkaudio.c @@ -93,6 +93,8 @@ static av_cold int decode_init(AVCodecContext *avctx) if (avctx->codec->id == AV_CODEC_ID_BINKAUDIO_RDFT) { // audio is already interleaved for the RDFT format variant avctx->sample_fmt = AV_SAMPLE_FMT_FLT; + if (sample_rate > INT_MAX / avctx->channels) + return AVERROR_INVALIDDATA; sample_rate *= avctx->channels; s->channels = 1; if (!s->version_b) |