diff options
| author | Michael Niedermayer <michael@niedermayer.cc> | 2020-09-24 22:20:39 +0200 |
|---|---|---|
| committer | Michael Niedermayer <michael@niedermayer.cc> | 2021-09-10 16:04:26 +0200 |
| commit | 8ab1d3e7f05bd38152ef425d160c5456bc71d541 (patch) | |
| tree | 94cf89e87da04ba5c90aaeaea710d4d7bcbd1b8c | |
| parent | e6be468b4a1f0d9d2ef6f3aa8b336884952dde41 (diff) | |
| download | ffmpeg-8ab1d3e7f05bd38152ef425d160c5456bc71d541.tar.gz | |
avcodec/sonic: Check channels before deallocating
Fixes: heap-buffer-overflow
Fixes: 25744/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SONIC_fuzzer-5172961169113088
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Reviewed-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit f249981976b18438cfb646183d4c21fb051e1ad4)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
| -rw-r--r-- | libavcodec/sonic.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/libavcodec/sonic.c b/libavcodec/sonic.c index b82c44344c..07bf21ffb6 100644 --- a/libavcodec/sonic.c +++ b/libavcodec/sonic.c @@ -980,9 +980,7 @@ static av_cold int sonic_decode_close(AVCodecContext *avctx) av_freep(&s->int_samples); av_freep(&s->tap_quant); av_freep(&s->predictor_k); - - for (i = 0; i < s->channels; i++) - { + for (i = 0; i < MAX_CHANNELS; i++) { av_freep(&s->predictor_state[i]); av_freep(&s->coded_samples[i]); } |