aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Niedermayer <michael@niedermayer.cc>2022-04-28 23:34:53 +0200
committerMichael Niedermayer <michael@niedermayer.cc>2022-07-02 21:07:04 +0200
commit8709f4c10a216cb3e11564bc392841e832f8e3b1 (patch)
treecb6c0acbdf523a7415b66e598eeb12998b3931e6
parent8154cb7c2ff2afcb1a0842de8c215b7714c814d0 (diff)
downloadffmpeg-8709f4c10a216cb3e11564bc392841e832f8e3b1.tar.gz
avcodec/alacdsp: Make intermediates unsigned
Fixes: signed integer overflow: -14914387 + -2147418648 cannot be represented in type 'int' Fixes: 46464/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALAC_fuzzer-474307197311385 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
-rw-r--r--libavcodec/alacdsp.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/libavcodec/alacdsp.c b/libavcodec/alacdsp.c
index f24c8112dc..b033a27970 100644
--- a/libavcodec/alacdsp.c
+++ b/libavcodec/alacdsp.c
@@ -29,12 +29,12 @@ static void decorrelate_stereo(int32_t *buffer[2], int nb_samples,
int i;
for (i = 0; i < nb_samples; i++) {
- int32_t a, b;
+ uint32_t a, b;
a = buffer[0][i];
b = buffer[1][i];
- a -= (int)(b * (unsigned)decorr_left_weight) >> decorr_shift;
+ a -= (int)(b * decorr_left_weight) >> decorr_shift;
b += a;
buffer[0][i] = b;