aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Niedermayer <michael@niedermayer.cc>2020-10-17 22:19:58 +0200
committerMichael Niedermayer <michael@niedermayer.cc>2021-10-09 22:02:19 +0200
commit86ec1f4707162259e1cc71cd6f98f7d565dcc9e9 (patch)
tree151e47661f674aba7f392d0568ce6ab9aadb3ccc
parent6455233ff5b96175f0c3ed07ba1c2579b525ac9f (diff)
downloadffmpeg-86ec1f4707162259e1cc71cd6f98f7d565dcc9e9.tar.gz
avformat/bethsoftvid: Check image dimensions before use
Fixes: signed integer overflow: 55255 * 53207 cannot be represented in type 'int' Fixes: 26387/clusterfuzz-testcase-minimized-ffmpeg_dem_AVS2_fuzzer-5684222226071552 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 50b29f081e9620dc39727adef707c2c323a8c095) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
-rw-r--r--libavformat/bethsoftvid.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/libavformat/bethsoftvid.c b/libavformat/bethsoftvid.c
index 752e05236d..5ecd26c5a9 100644
--- a/libavformat/bethsoftvid.c
+++ b/libavformat/bethsoftvid.c
@@ -28,6 +28,7 @@
*/
#include "libavutil/channel_layout.h"
+#include "libavutil/imgutils.h"
#include "libavutil/intreadwrite.h"
#include "avformat.h"
#include "internal.h"
@@ -71,6 +72,7 @@ static int vid_read_header(AVFormatContext *s)
{
BVID_DemuxContext *vid = s->priv_data;
AVIOContext *pb = s->pb;
+ int ret;
/* load main header. Contents:
* bytes: 'V' 'I' 'D'
@@ -83,6 +85,10 @@ static int vid_read_header(AVFormatContext *s)
vid->bethsoft_global_delay = avio_rl16(pb);
avio_rl16(pb);
+ ret = av_image_check_size(vid->width, vid->height, 0, s);
+ if (ret < 0)
+ return ret;
+
// wait until the first packet to create each stream
vid->video_index = -1;
vid->audio_index = -1;