aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAnton Khirnov <anton@khirnov.net>2022-09-15 15:53:12 +0200
committerAnton Khirnov <anton@khirnov.net>2022-09-19 15:18:20 +0200
commit8576c3c5d82188c1313f20666b8760fe4a29444c (patch)
tree5fd034343afd67917d8981b5e90e06ac8cdccff3
parentd7f4ad88a0df3c1339e142957bf2c40cd056b8ce (diff)
downloadffmpeg-8576c3c5d82188c1313f20666b8760fe4a29444c.tar.gz
lavc/videotoolbox: deprecate write-only output_callback
This field has never been used for anything, so stop setting it and deprecate it.
-rw-r--r--libavcodec/version_major.h1
-rw-r--r--libavcodec/videotoolbox.c2
-rw-r--r--libavcodec/videotoolbox.h5
3 files changed, 6 insertions, 2 deletions
diff --git a/libavcodec/version_major.h b/libavcodec/version_major.h
index 1ec815a7bc..d9386792de 100644
--- a/libavcodec/version_major.h
+++ b/libavcodec/version_major.h
@@ -51,5 +51,6 @@
#define FF_API_IDCT_NONE (LIBAVCODEC_VERSION_MAJOR < 60)
#define FF_API_SVTAV1_OPTS (LIBAVCODEC_VERSION_MAJOR < 60)
#define FF_API_AYUV_CODECID (LIBAVCODEC_VERSION_MAJOR < 60)
+#define FF_API_VT_OUTPUT_CALLBACK (LIBAVCODEC_VERSION_MAJOR < 60)
#endif /* AVCODEC_VERSION_MAJOR_H */
diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c
index d61d310600..1b1be8ddb4 100644
--- a/libavcodec/videotoolbox.c
+++ b/libavcodec/videotoolbox.c
@@ -1377,8 +1377,6 @@ static AVVideotoolboxContext *av_videotoolbox_alloc_context_with_pix_fmt(enum AV
AVVideotoolboxContext *ret = av_mallocz(sizeof(*ret));
if (ret) {
- ret->output_callback = videotoolbox_decoder_callback;
-
OSType cv_pix_fmt_type = av_map_videotoolbox_format_from_pixfmt2(pix_fmt, full_range);
if (cv_pix_fmt_type == 0) {
cv_pix_fmt_type = kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange;
diff --git a/libavcodec/videotoolbox.h b/libavcodec/videotoolbox.h
index af2db0d580..fd8a5b7982 100644
--- a/libavcodec/videotoolbox.h
+++ b/libavcodec/videotoolbox.h
@@ -37,6 +37,8 @@
#include "libavcodec/avcodec.h"
+#include "libavutil/attributes.h"
+
/**
* This struct holds all the information that needs to be passed
* between the caller and libavcodec for initializing Videotoolbox decoding.
@@ -50,11 +52,14 @@ typedef struct AVVideotoolboxContext {
*/
VTDecompressionSessionRef session;
+#if FF_API_VT_OUTPUT_CALLBACK
/**
* The output callback that must be passed to the session.
* Set by av_videottoolbox_default_init()
*/
+ attribute_deprecated
VTDecompressionOutputCallback output_callback;
+#endif
/**
* CVPixelBuffer Format Type that Videotoolbox will use for decoded frames.