aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
author孙浩 and 张洪亮(望初) <tony.sh and wangchu.zhl@alibaba-inc.com>2017-08-25 01:15:28 +0200
committerMichael Niedermayer <michael@niedermayer.cc>2017-08-28 01:42:34 +0200
commit81e6a95e54ff197251570359dbc39b5b779fe972 (patch)
treeebe244205abe11538905c4f1ce65add40dd27dde
parentadca94d65e5c70d9fc104abc38081fa147d7f046 (diff)
downloadffmpeg-81e6a95e54ff197251570359dbc39b5b779fe972.tar.gz
avformat/rmdec: Fix DoS due to lack of eof check
Fixes: loop.ivr Found-by: Xiaohei and Wangchu from Alibaba Security Team Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 124eb202e70678539544f6268efc98131f19fa49) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
-rw-r--r--libavformat/rmdec.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/libavformat/rmdec.c b/libavformat/rmdec.c
index 1a61b10d44..fa65998769 100644
--- a/libavformat/rmdec.c
+++ b/libavformat/rmdec.c
@@ -1231,8 +1231,11 @@ static int ivr_read_header(AVFormatContext *s)
av_log(s, AV_LOG_DEBUG, "%s = '%s'\n", key, val);
} else if (type == 4) {
av_log(s, AV_LOG_DEBUG, "%s = '0x", key);
- for (j = 0; j < len; j++)
+ for (j = 0; j < len; j++) {
+ if (avio_feof(pb))
+ return AVERROR_INVALIDDATA;
av_log(s, AV_LOG_DEBUG, "%X", avio_r8(pb));
+ }
av_log(s, AV_LOG_DEBUG, "'\n");
} else if (len == 4 && type == 3 && !strncmp(key, "StreamCount", tlen)) {
nb_streams = value = avio_rb32(pb);