diff options
| author | Martin Storsjö <martin@martin.st> | 2013-09-29 13:02:27 +0300 |
|---|---|---|
| committer | Luca Barbato <lu_zero@gentoo.org> | 2013-10-04 03:52:11 +0200 |
| commit | 7e350b7ddd19af856b55634233d609e29baab646 (patch) | |
| tree | 6d06410621e8a8874eccbc4f88e83b3a106b4bf1 | |
| parent | f06e39fe6b272a11782c023c31eec43bfce3138d (diff) | |
| download | ffmpeg-7e350b7ddd19af856b55634233d609e29baab646.tar.gz | |
pcx: Check the packet size before assuming it fits a palette
This fixes reads out of bounds.
Reported-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
Signed-off-by: Martin Storsjö <martin@martin.st>
(cherry picked from commit d1d99e3befea5d411ac3aae72dbdecce94f8b547)
Signed-off-by: Luca Barbato <lu_zero@gentoo.org>
Conflicts:
libavcodec/pcx.c
| -rw-r--r-- | libavcodec/pcx.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/libavcodec/pcx.c b/libavcodec/pcx.c index 9c79aff1ae..223429d35e 100644 --- a/libavcodec/pcx.c +++ b/libavcodec/pcx.c @@ -184,7 +184,13 @@ static int pcx_decode_frame(AVCodecContext *avctx, void *data, int *got_frame, } else if (nplanes == 1 && bits_per_pixel == 8) { const uint8_t *palstart = bufstart + buf_size - 769; - for (y=0; y<h; y++, ptr+=stride) { + if (buf_size < 769) { + av_log(avctx, AV_LOG_ERROR, "File is too short\n"); + ret = buf_size; + goto end; + } + + for (y = 0; y < h; y++, ptr += stride) { buf = pcx_rle_decode(buf, buf_end, scanline, bytes_per_scanline, compressed); memcpy(ptr, scanline, w); |