diff options
| author | Ganesh Ajjanagadde <gajjanag@gmail.com> | 2016-02-24 20:47:00 -0500 |
|---|---|---|
| committer | Ganesh Ajjanagadde <gajjanag@gmail.com> | 2016-02-29 19:26:55 -0500 |
| commit | 7dabc78ce13e3baa37292f42df2364b4ccd2aa78 (patch) | |
| tree | 334dfd878902f4b9e00a5dd0efc45f596820e382 | |
| parent | 380fd32a8ccd908dcd484a35dafd5f3d3b5e22db (diff) | |
| download | ffmpeg-7dabc78ce13e3baa37292f42df2364b4ccd2aa78.tar.gz | |
lavu/rational: add more info regarding floor(x+0.5) usage
Add some more verbose info regarding why the imprecise and slow floor(x+0.5) hack
is used; helpful for future maintenance.
Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Ganesh Ajjanagadde <gajjanag@gmail.com>
| -rw-r--r-- | libavutil/rational.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/libavutil/rational.c b/libavutil/rational.c index 6b3f50a02a..cab443818a 100644 --- a/libavutil/rational.c +++ b/libavutil/rational.c @@ -115,7 +115,8 @@ AVRational av_d2q(double d, int max) frexp(d, &exponent); exponent = FFMAX(exponent-1, 0); den = 1LL << (61 - exponent); - // (int64_t)rint() and llrint() do not work with gcc on ia64 and sparc64 + // (int64_t)rint() and llrint() do not work with gcc on ia64 and sparc64, + // see Ticket2713 for affected gcc/glibc versions av_reduce(&a.num, &a.den, floor(d * den + 0.5), den, max); if ((!a.num || !a.den) && d && max>0 && max<INT_MAX) av_reduce(&a.num, &a.den, floor(d * den + 0.5), den, INT_MAX); |