aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJustin Ruggles <justin.ruggles@gmail.com>2011-09-14 13:57:04 -0400
committerJustin Ruggles <justin.ruggles@gmail.com>2011-10-03 21:34:19 -0400
commit7d49f79f1cd47783a963a757a6563b9cac29db62 (patch)
tree9ac08e5aa184cb1c8bd39416ed4ac13e6e540cf3
parent5a19acb17ceb71657b0eec51dac651953520e5c8 (diff)
downloadffmpeg-7d49f79f1cd47783a963a757a6563b9cac29db62.tar.gz
qdm2: check output buffer size before decoding
-rw-r--r--libavcodec/qdm2.c11
1 files changed, 9 insertions, 2 deletions
diff --git a/libavcodec/qdm2.c b/libavcodec/qdm2.c
index b68197de17..5068e675cb 100644
--- a/libavcodec/qdm2.c
+++ b/libavcodec/qdm2.c
@@ -1960,13 +1960,20 @@ static int qdm2_decode_frame(AVCodecContext *avctx,
int buf_size = avpkt->size;
QDM2Context *s = avctx->priv_data;
int16_t *out = data;
- int i;
+ int i, out_size;
if(!buf)
return 0;
if(buf_size < s->checksum_size)
return -1;
+ out_size = 16 * s->channels * s->frame_size *
+ av_get_bytes_per_sample(avctx->sample_fmt);
+ if (*data_size < out_size) {
+ av_log(avctx, AV_LOG_ERROR, "Output buffer is too small\n");
+ return AVERROR(EINVAL);
+ }
+
av_log(avctx, AV_LOG_DEBUG, "decode(%d): %p[%d] -> %p[%d]\n",
buf_size, buf, s->checksum_size, data, *data_size);
@@ -1976,7 +1983,7 @@ static int qdm2_decode_frame(AVCodecContext *avctx,
out += s->channels * s->frame_size;
}
- *data_size = (uint8_t*)out - (uint8_t*)data;
+ *data_size = out_size;
return s->checksum_size;
}