diff options
| author | Michael Niedermayer <michael@niedermayer.cc> | 2022-03-20 22:54:31 +0100 |
|---|---|---|
| committer | Michael Niedermayer <michael@niedermayer.cc> | 2022-04-06 20:27:35 +0200 |
| commit | 79ad18ddbd2f7feee33e24bff02afe4c10928b75 (patch) | |
| tree | c15cb68711e7c718fc5870b8d125c0386e3103da | |
| parent | b27833f06689eb0e44e2f044d8d4db8b831affed (diff) | |
| download | ffmpeg-79ad18ddbd2f7feee33e24bff02afe4c10928b75.tar.gz | |
avformat/hls: Check target_duration
Fixes: signed integer overflow: 77777777777777 * 1000000 cannot be represented in type 'long long'
Fixes: 45545/clusterfuzz-testcase-minimized-ffmpeg_dem_HLS_fuzzer-6438101247983616
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Reviewed-by: Steven Liu <lingjiujianke@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit a8fd3f7fab83e1beea1c441e1a2e538e7aa431a5)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
| -rw-r--r-- | libavformat/hls.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/libavformat/hls.c b/libavformat/hls.c index 75209906d3..f2ca4f3443 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -810,10 +810,16 @@ static int parse_playlist(HLSContext *c, const char *url, &info); new_rendition(c, &info, url); } else if (av_strstart(line, "#EXT-X-TARGETDURATION:", &ptr)) { + int64_t t; ret = ensure_playlist(c, &pls, url); if (ret < 0) goto fail; - pls->target_duration = strtoll(ptr, NULL, 10) * AV_TIME_BASE; + t = strtoll(ptr, NULL, 10); + if (t < 0 || t >= INT64_MAX / AV_TIME_BASE) { + ret = AVERROR_INVALIDDATA; + goto fail; + } + pls->target_duration = t * AV_TIME_BASE; } else if (av_strstart(line, "#EXT-X-MEDIA-SEQUENCE:", &ptr)) { uint64_t seq_no; ret = ensure_playlist(c, &pls, url); |