diff options
| author | Martin Storsjö <martin@martin.st> | 2013-09-19 16:55:13 +0300 |
|---|---|---|
| committer | Luca Barbato <lu_zero@gentoo.org> | 2013-10-04 03:26:28 +0200 |
| commit | 78dc022f6f8a8b87773a209e0fcbea2d5b48396f (patch) | |
| tree | d676a483f6544dfbd75740a656097987884aa772 | |
| parent | 5379c5184b9fe9ef06234638f5629d4c80056e04 (diff) | |
| download | ffmpeg-78dc022f6f8a8b87773a209e0fcbea2d5b48396f.tar.gz | |
wtv: Add more sanity checks for a length read from the file
Also make sure the existing length check can't overflow.
Reported-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
Signed-off-by: Martin Storsjö <martin@martin.st>
(cherry picked from commit 83c285f88016b087c2f0f4b9ef356ad8ef12d947)
Signed-off-by: Luca Barbato <lu_zero@gentoo.org>
| -rw-r--r-- | libavformat/wtv.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/libavformat/wtv.c b/libavformat/wtv.c index 1811e4645c..7f029ff369 100644 --- a/libavformat/wtv.c +++ b/libavformat/wtv.c @@ -274,7 +274,12 @@ static AVIOContext * wtvfile_open2(AVFormatContext *s, const uint8_t *buf, int b dir_length = AV_RL16(buf + 16); file_length = AV_RL64(buf + 24); name_size = 2 * AV_RL32(buf + 32); - if (buf + 48 + name_size > buf_end) { + if (name_size < 0) { + av_log(s, AV_LOG_ERROR, + "bad filename length, remaining directory entries ignored\n"); + break; + } + if (48 + name_size > buf_end - buf) { av_log(s, AV_LOG_ERROR, "filename exceeds buffer size; remaining directory entries ignored\n"); break; } |