aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLuca Barbato <lu_zero@gentoo.org>2015-03-14 12:30:11 +0100
committerMichael Niedermayer <michaelni@gmx.at>2015-05-21 20:43:37 +0200
commit77059eedb50e01bec38f63dfc4672d8f0a60fed5 (patch)
tree3c413c2aa2019b85b53c980c632565f526d5b6dd
parent31601db12a153b290434272db9d81fe37fa9fb90 (diff)
downloadffmpeg-77059eedb50e01bec38f63dfc4672d8f0a60fed5.tar.gz
xcbgrab: Validate the capture area
And notify why the capture is impossible. Signed-off-by: Luca Barbato <lu_zero@gentoo.org> (cherry picked from commit e8c4db0d4d07738fed716b1d2f20c85aac944641) Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
-rw-r--r--libavdevice/xcbgrab.c13
1 files changed, 11 insertions, 2 deletions
diff --git a/libavdevice/xcbgrab.c b/libavdevice/xcbgrab.c
index e9f2fefa2b..292597877b 100644
--- a/libavdevice/xcbgrab.c
+++ b/libavdevice/xcbgrab.c
@@ -527,8 +527,17 @@ static int create_stream(AVFormatContext *s)
gc = xcb_get_geometry(c->conn, c->screen->root);
geo = xcb_get_geometry_reply(c->conn, gc, NULL);
- c->width = FFMIN(geo->width, c->width);
- c->height = FFMIN(geo->height, c->height);
+ if (c->x + c->width >= geo->width ||
+ c->y + c->height >= geo->height) {
+ av_log(s, AV_LOG_ERROR,
+ "Capture area %dx%d at position %d.%d "
+ "outside the screen size %dx%d\n",
+ c->width, c->height,
+ c->x, c->y,
+ geo->width, geo->height);
+ return AVERROR(EINVAL);
+ }
+
c->time_base = (AVRational){ st->avg_frame_rate.den,
st->avg_frame_rate.num };
c->time_frame = av_gettime();