aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndreas Rheinhardt <andreas.rheinhardt@gmail.com>2020-03-21 07:31:17 +0100
committerAndreas Rheinhardt <andreas.rheinhardt@gmail.com>2020-07-02 23:56:12 +0200
commit766b1b6a25866547cae77fee0f8a7c177787e460 (patch)
treebffc62b466476cca0143b0f7aeeca73222523b88
parentd001c06f8223c7ccb41c6075949dd27de25fcf90 (diff)
downloadffmpeg-766b1b6a25866547cae77fee0f8a7c177787e460.tar.gz
avformat/hnm: Check for extradata allocation failure
and also add padding to it; moreover, don't use memcpy to write one byte to extradata. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> Reviewed-by: Paul B Mahol <onemda@gmail.com> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 9e0f3352d1f37a739d98df4347a2b60a396a56fe) Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
-rw-r--r--libavformat/hnm.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/libavformat/hnm.c b/libavformat/hnm.c
index 24d4e808a5..9ad457ac83 100644
--- a/libavformat/hnm.c
+++ b/libavformat/hnm.c
@@ -70,6 +70,7 @@ static int hnm_read_header(AVFormatContext *s)
Hnm4DemuxContext *hnm = s->priv_data;
AVIOContext *pb = s->pb;
AVStream *vst;
+ int ret;
/* default context members */
hnm->pts = 0;
@@ -113,10 +114,10 @@ static int hnm_read_header(AVFormatContext *s)
vst->codecpar->codec_tag = 0;
vst->codecpar->width = hnm->width;
vst->codecpar->height = hnm->height;
- vst->codecpar->extradata = av_mallocz(1);
+ if ((ret = ff_alloc_extradata(vst->codecpar, 1)) < 0)
+ return ret;
- vst->codecpar->extradata_size = 1;
- memcpy(vst->codecpar->extradata, &hnm->version, 1);
+ vst->codecpar->extradata[0] = hnm->version;
vst->start_time = 0;