aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAnton Khirnov <anton@khirnov.net>2013-03-28 10:34:47 +0100
committerReinhard Tartler <siretart@tauware.de>2013-04-06 11:40:20 +0200
commit75948682969694613e5226cd48c248eacfa9a425 (patch)
tree23ec38116193fcf9a005e814e1e3ac96faaa339c
parent09e391abd81c3298e230bebb3c4ce159a259d871 (diff)
downloadffmpeg-75948682969694613e5226cd48c248eacfa9a425.tar.gz
xmv: do not leak memory in the error paths in xmv_read_header()
CC: libav-stable@libav.org (cherry picked from commit f8080bd13b5f7fc48204b17fa59a5ce9feb15f07) Signed-off-by: Reinhard Tartler <siretart@tauware.de>
-rw-r--r--libavformat/xmv.c12
1 files changed, 8 insertions, 4 deletions
diff --git a/libavformat/xmv.c b/libavformat/xmv.c
index 3f926eff9c..6c46a23e86 100644
--- a/libavformat/xmv.c
+++ b/libavformat/xmv.c
@@ -177,8 +177,10 @@ static int xmv_read_header(AVFormatContext *s)
return AVERROR(ENOMEM);
xmv->audio = av_malloc(xmv->audio_track_count * sizeof(XMVAudioPacket));
- if (!xmv->audio)
- return AVERROR(ENOMEM);
+ if (!xmv->audio) {
+ ret = AVERROR(ENOMEM);
+ goto fail;
+ }
for (audio_track = 0; audio_track < xmv->audio_track_count; audio_track++) {
XMVAudioTrack *track = &xmv->audio_tracks[audio_track];
@@ -212,8 +214,10 @@ static int xmv_read_header(AVFormatContext *s)
"(0x%04X)\n", track->flags);
ast = avformat_new_stream(s, NULL);
- if (!ast)
- return AVERROR(ENOMEM);
+ if (!ast) {
+ ret = AVERROR(ENOMEM);
+ goto fail;
+ }
ast->codec->codec_type = AVMEDIA_TYPE_AUDIO;
ast->codec->codec_id = track->codec_id;