aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Niedermayer <michael@niedermayer.cc>2019-10-17 20:56:23 +0200
committerMichael Niedermayer <michael@niedermayer.cc>2019-12-31 19:51:56 +0100
commit72c9dab15d8e528721595975c5d872d6aba29ec0 (patch)
tree806fcf38788d62c9ee920857893a933e6d00a158
parentf9738b2af3d4127d495b6841f04b75f03badf4d8 (diff)
downloadffmpeg-72c9dab15d8e528721595975c5d872d6aba29ec0.tar.gz
avcodec/apedec: Fix undefined integer overflow in long_filter_ehigh_3830()
Fixes: signed integer overflow: -1094995529 * 2 cannot be represented in type 'int' Fixes: 18281/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5692589180715008 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 1d1719a44dd43b2d9d8ccd26e3b2854e675a7bd7) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
-rw-r--r--libavcodec/apedec.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/libavcodec/apedec.c b/libavcodec/apedec.c
index 9409a4727d..315bd162d5 100644
--- a/libavcodec/apedec.c
+++ b/libavcodec/apedec.c
@@ -916,7 +916,8 @@ static void long_filter_ehigh_3830(int32_t *buffer, int length)
{
int i, j;
int32_t dotprod, sign;
- int32_t coeffs[8] = { 0 }, delay[8] = { 0 };
+ int32_t delay[8] = { 0 };
+ uint32_t coeffs[8] = { 0 };
for (i = 0; i < length; i++) {
dotprod = 0;