diff options
| author | Michael Niedermayer <michael@niedermayer.cc> | 2022-03-20 22:54:31 +0100 |
|---|---|---|
| committer | Michael Niedermayer <michael@niedermayer.cc> | 2022-03-28 23:14:15 +0200 |
| commit | 6d4c5f4e2b3c4101bcd026666855bf5d8bdbdd5b (patch) | |
| tree | 5b63da93249c6a59e4a1951b1d07d74149655232 | |
| parent | 73bb1853b2fb305f77fdff795cd12d65d82894fb (diff) | |
| download | ffmpeg-6d4c5f4e2b3c4101bcd026666855bf5d8bdbdd5b.tar.gz | |
avformat/hls: Check target_duration
Fixes: signed integer overflow: 77777777777777 * 1000000 cannot be represented in type 'long long'
Fixes: 45545/clusterfuzz-testcase-minimized-ffmpeg_dem_HLS_fuzzer-6438101247983616
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Reviewed-by: Steven Liu <lingjiujianke@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit a8fd3f7fab83e1beea1c441e1a2e538e7aa431a5)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
| -rw-r--r-- | libavformat/hls.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/libavformat/hls.c b/libavformat/hls.c index 7915ee7996..0b55507790 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -742,10 +742,16 @@ static int parse_playlist(HLSContext *c, const char *url, &info); new_rendition(c, &info, url); } else if (av_strstart(line, "#EXT-X-TARGETDURATION:", &ptr)) { + int64_t t; ret = ensure_playlist(c, &pls, url); if (ret < 0) goto fail; - pls->target_duration = strtoll(ptr, NULL, 10) * AV_TIME_BASE; + t = strtoll(ptr, NULL, 10); + if (t < 0 || t >= INT64_MAX / AV_TIME_BASE) { + ret = AVERROR_INVALIDDATA; + goto fail; + } + pls->target_duration = t * AV_TIME_BASE; } else if (av_strstart(line, "#EXT-X-MEDIA-SEQUENCE:", &ptr)) { ret = ensure_playlist(c, &pls, url); if (ret < 0) |