aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Niedermayer <michael@niedermayer.cc>2020-12-18 00:31:08 +0100
committerMichael Niedermayer <michael@niedermayer.cc>2021-09-10 16:04:26 +0200
commit6bc7e2bd6ed75d2344449cf6aa2164c3ec7578ba (patch)
treef67c757a0f023f696dbd558f9645d14c090912a1
parentd4c2967a35622fd38677e8ceb1c96ec0f3f67fd0 (diff)
downloadffmpeg-6bc7e2bd6ed75d2344449cf6aa2164c3ec7578ba.tar.gz
avcodec/simple_idct: Fix undefined integer overflow in idct4row()
Fixes: signed integer overflow: -1498310196 - 902891776 cannot be represented in type 'int' Fixes: 28445/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VC1IMAGE_fuzzer-5075163389493248 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 57f7e5caa324fd760aa9e134ee963e9936083c59) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
-rw-r--r--libavcodec/simple_idct.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/libavcodec/simple_idct.c b/libavcodec/simple_idct.c
index 3b2e736538..0ef167491a 100644
--- a/libavcodec/simple_idct.c
+++ b/libavcodec/simple_idct.c
@@ -175,7 +175,8 @@ static inline void idct4col_add(uint8_t *dest, ptrdiff_t line_size, const int16_
#define R_SHIFT 11
static inline void idct4row(int16_t *row)
{
- int c0, c1, c2, c3, a0, a1, a2, a3;
+ unsigned c0, c1, c2, c3;
+ int a0, a1, a2, a3;
a0 = row[0];
a1 = row[1];