avformat/http: Fix double-free on error

av_dict_set() with AV_DICT_DONT_STRDUP_VAL takes ownership
of the string it is passed to as val; this includes freeing it
on error.

Fixes Coverity issue #1497468.

Reviewed-by: Eran Kornblau <eran.kornblau@kaltura.com>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>

1 files changed, 1 insertions, 3 deletions

diff --git a/libavformat/http.c b/libavformat/http.c
index e8096e3134..8f39d11a88 100644
--- a/libavformat/http.c
+++ b/libavformat/http.c
@@ -333,10 +333,8 @@ static int redirect_cache_set(HTTPContext *s, const char *source, const char *de
     }
 
     ret = av_dict_set(&s->redirect_cache, source, value, AV_DICT_MATCH_CASE | AV_DICT_DONT_STRDUP_VAL);
-    if (ret < 0) {
-        av_free(value);
+    if (ret < 0)
         return ret;
-    }
 
     return 0;
 }