diff options
| author | Andreas Rheinhardt <andreas.rheinhardt@gmail.com> | 2020-05-24 03:14:00 +0200 |
|---|---|---|
| committer | Andreas Rheinhardt <andreas.rheinhardt@gmail.com> | 2020-07-02 23:56:13 +0200 |
| commit | 6132ea3daf23fb03314f7fc00275f438a1cea07e (patch) | |
| tree | 8b0ac548e126d156820af20094ca08e227b4f494 | |
| parent | b7d11cc6e850225eab4c501211edbab57b9acef8 (diff) | |
| download | ffmpeg-6132ea3daf23fb03314f7fc00275f438a1cea07e.tar.gz | |
avformat/aviobuf: Don't check for overflow after it happened
If adding two ints overflows, it doesn't matter whether the result will
be stored in an unsigned or not; and checking afterwards does not make it
retroactively defined.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
(cherry picked from commit 28a078eded1c29985ed078b59d48ff59cf00394b)
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
| -rw-r--r-- | libavformat/aviobuf.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c index c004e08bdf..2d31ab948f 100644 --- a/libavformat/aviobuf.c +++ b/libavformat/aviobuf.c @@ -1231,7 +1231,7 @@ static int dyn_buf_write(void *opaque, uint8_t *buf, int buf_size) unsigned new_size, new_allocated_size; /* reallocate buffer if needed */ - new_size = d->pos + buf_size; + new_size = (unsigned)d->pos + buf_size; new_allocated_size = d->allocated_size; if (new_size < d->pos || new_size > INT_MAX/2) return -1; |