aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Niedermayer <michael@niedermayer.cc>2017-02-20 12:31:43 +0100
committerMichael Niedermayer <michael@niedermayer.cc>2017-05-16 16:00:21 +0200
commit5fcb98f34f5a5f8ce4d92d32362f20c12347364a (patch)
treedaa5a848f7f8e83f3afe58d840eec61d1b516866
parentad2f9874b5cccf553dbbcced23799c941dd77c8f (diff)
downloadffmpeg-5fcb98f34f5a5f8ce4d92d32362f20c12347364a.tar.gz
avcodec/pictordec: Do not read more than nb_planes
Fixes undefined behavior Fixes: 622/clusterfuzz-testcase-5745722022428672 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 01d196a67dc55eb01cf3e06d6338c5d096a29b1c) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
-rw-r--r--libavcodec/pictordec.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/libavcodec/pictordec.c b/libavcodec/pictordec.c
index 0cfc785832..a3d72e3f25 100644
--- a/libavcodec/pictordec.c
+++ b/libavcodec/pictordec.c
@@ -80,7 +80,7 @@ static void picmemset(PicContext *s, AVFrame *frame, int value, int run,
value <<= bits_per_plane;
mask <<= bits_per_plane;
if (*plane >= s->nb_planes)
- break;
+ return;
}
}
}
@@ -236,7 +236,7 @@ static int decode_frame(AVCodecContext *avctx,
}
}
- if (x < avctx->width) {
+ if (plane < s->nb_planes && x < avctx->width) {
int run = (y + 1) * avctx->width - x;
if (bits_per_plane == 8)
picmemset_8bpp(s, frame, val, run, &x, &y);