diff options
| author | Michael Niedermayer <michael@niedermayer.cc> | 2021-04-26 22:43:51 +0200 |
|---|---|---|
| committer | Michael Niedermayer <michael@niedermayer.cc> | 2021-09-11 21:23:49 +0200 |
| commit | 5f44a99a603bf3d95d56cd574ea7aee99d43485b (patch) | |
| tree | 7b962d9e9000e7511b360f8ddf7038e3f5bdd020 | |
| parent | a3f8ddabde93acc67e6fcb5a0d35cb7a515d7272 (diff) | |
| download | ffmpeg-5f44a99a603bf3d95d56cd574ea7aee99d43485b.tar.gz | |
avformat/rpl: Use 64bit in bitrate computation and check it
Fixes: signed integer overflow: 777777776 * 4 cannot be represented in type 'int'
Fixes: 29102/clusterfuzz-testcase-minimized-ffmpeg_dem_RPL_fuzzer-6726188921913344
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 29b244ffc15abe2c24d2145f63048e8b3bdaa303)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
| -rw-r--r-- | libavformat/rpl.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/libavformat/rpl.c b/libavformat/rpl.c index d6d81549b0..0b97699ca3 100644 --- a/libavformat/rpl.c +++ b/libavformat/rpl.c @@ -195,8 +195,10 @@ static int rpl_read_header(AVFormatContext *s) ast->codecpar->bits_per_coded_sample = 4; ast->codecpar->bit_rate = ast->codecpar->sample_rate * - ast->codecpar->bits_per_coded_sample * - ast->codecpar->channels; + (int64_t)ast->codecpar->channels; + if (ast->codecpar->bit_rate > INT64_MAX / ast->codecpar->bits_per_coded_sample) + return AVERROR_INVALIDDATA; + ast->codecpar->bit_rate *= ast->codecpar->bits_per_coded_sample; ast->codecpar->codec_id = AV_CODEC_ID_NONE; switch (audio_format) { |