diff options
| author | Michael Niedermayer <michaelni@gmx.at> | 2015-03-14 21:32:35 +0100 |
|---|---|---|
| committer | Michael Niedermayer <michaelni@gmx.at> | 2015-04-22 12:27:24 +0200 |
| commit | 5922e5a84eb3bcd19c09def7046a595dece989d3 (patch) | |
| tree | 35426d32a5d18d4153583eea45a3e0eb5b890523 | |
| parent | f000df4ce2a70bbbdfbd9efb7650f970ed65bd19 (diff) | |
| download | ffmpeg-5922e5a84eb3bcd19c09def7046a595dece989d3.tar.gz | |
avformat/mov: Disallow ".." in dref unless use_absolute_path is set
as this kind of allows to circumvent it to some extend.
We also could add a separate parameter or value to choose this
Found-by: ramiro
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
(cherry picked from commit 1e4d0498df6621143da1a550006ddc3526ad51cb)
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
| -rw-r--r-- | libavformat/mov.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/libavformat/mov.c b/libavformat/mov.c index 97e02b4a53..1e550177ce 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -2315,6 +2315,9 @@ static int mov_open_dref(AVIOContext **pb, const char *src, MOVDref *ref, av_strlcat(filename, "../", sizeof(filename)); av_strlcat(filename, ref->path + l + 1, sizeof(filename)); + if (!use_absolute_path) + if(strstr(ref->path + l + 1, "..") || ref->nlvl_from > 1) + return AVERROR(ENOENT); if (strlen(filename) + 1 == sizeof(filename)) return AVERROR(ENOENT); |