diff options
| author | Michael Niedermayer <michael@niedermayer.cc> | 2017-05-10 14:41:23 +0200 |
|---|---|---|
| committer | Michael Niedermayer <michael@niedermayer.cc> | 2017-05-10 15:21:10 +0200 |
| commit | 5871adc90f8c1037535563e33ebeaf032bb4d5d6 (patch) | |
| tree | 4e32a55e41a78b4e566928f28a779ce670312816 | |
| parent | 3d8d3729475c7dce52d8fb9ffb280fd2ea62e1a2 (diff) | |
| download | ffmpeg-5871adc90f8c1037535563e33ebeaf032bb4d5d6.tar.gz | |
avcodec/cavs: Check updated MV
Fixes: runtime error: signed integer overflow: 251 + 2147483647 cannot be represented in type 'int'
Fixes: 1438/clusterfuzz-testcase-minimized-4917542646710272
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
| -rw-r--r-- | libavcodec/cavs.c | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/libavcodec/cavs.c b/libavcodec/cavs.c index 549fb9eefd..40bb63a278 100644 --- a/libavcodec/cavs.c +++ b/libavcodec/cavs.c @@ -613,8 +613,15 @@ void ff_cavs_mv(AVSContext *h, enum cavs_mv_loc nP, enum cavs_mv_loc nC, mv_pred_median(h, mvP, mvA, mvB, mvC); if (mode < MV_PRED_PSKIP) { - mvP->x += get_se_golomb(&h->gb); - mvP->y += get_se_golomb(&h->gb); + int mx = get_se_golomb(&h->gb) + (unsigned)mvP->x; + int my = get_se_golomb(&h->gb) + (unsigned)mvP->y; + + if (mx != (int16_t)mx || my != (int16_t)my) { + av_log(h->avctx, AV_LOG_ERROR, "MV %d %d out of supported range\n", mx, my); + } else { + mvP->x = mx; + mvP->y = my; + } } set_mvs(mvP, size); } |