aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Niedermayer <michael@niedermayer.cc>2019-12-16 23:31:22 +0100
committerMichael Niedermayer <michael@niedermayer.cc>2020-07-01 12:49:26 +0200
commit54152c08f634174674ed1b6fe2e080f626defa45 (patch)
treedd0f9a48c99ed795bfcc1f22183724ce97531a26
parenta97438c354367e5ed87a9541f30ed5a9e992bedd (diff)
downloadffmpeg-54152c08f634174674ed1b6fe2e080f626defa45.tar.gz
avcodec/vc1dec: Free sprite_output_frame on error
Fixes: memleaks Fixes: 19471/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VC1IMAGE_fuzzer-5688035714269184 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 3ee9240be3e4044ae9e60a9a3a68820bf8075299) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
-rw-r--r--libavcodec/vc1dec.c11
1 files changed, 9 insertions, 2 deletions
diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c
index 22ceec50a1..2b2604766f 100644
--- a/libavcodec/vc1dec.c
+++ b/libavcodec/vc1dec.c
@@ -576,14 +576,21 @@ static av_cold int vc1_decode_init(AVCodecContext *avctx)
if (v->sprite_width > 1 << 14 ||
v->sprite_height > 1 << 14 ||
v->output_width > 1 << 14 ||
- v->output_height > 1 << 14) return -1;
+ v->output_height > 1 << 14) {
+ ret = -1;
+ goto error;
+ }
if ((v->sprite_width&1) || (v->sprite_height&1)) {
avpriv_request_sample(avctx, "odd sprites support");
- return AVERROR_PATCHWELCOME;
+ ret = AVERROR_PATCHWELCOME;
+ goto error;
}
}
return 0;
+error:
+ av_frame_free(&v->sprite_output_frame);
+ return ret;
}
/** Close a VC1/WMV3 decoder