aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHaihao Xiang <haihao.xiang@intel.com>2022-11-28 12:43:19 +0800
committerHaihao Xiang <haihao.xiang@intel.com>2022-12-01 09:39:32 +0800
commit51bad2e6a73f8edd09139107b6fc43b4ed200162 (patch)
treebedb4844dd95b35e19b3ed87a640eb383b8f0163
parent50575e24bef05ccc1e42f382a9f96896d49e9457 (diff)
downloadffmpeg-51bad2e6a73f8edd09139107b6fc43b4ed200162.tar.gz
lavfi/qsvvpp: avoid overriding the returned value
It means more than one output is ready when MFXVideoVPP_RunFrameVPPAsync() returns MFX_ERR_MORE_SURFACE [1]. Currently the returned value from MFXVideoVPP_RunFrameVPPAsync() might be overridden, so the check of 'ret == MFX_ERR_MORE_SURFACE' is always false when MFX_ERR_MORE_SURFACE is returned from MFXVideoVPP_RunFrameVPPAsync() [1] https://github.com/Intel-Media-SDK/MediaSDK/blob/master/doc/mediasdk-man.md#video-processing-procedures Signed-off-by: Haihao Xiang <haihao.xiang@intel.com>
-rw-r--r--libavfilter/qsvvpp.c11
1 files changed, 8 insertions, 3 deletions
diff --git a/libavfilter/qsvvpp.c b/libavfilter/qsvvpp.c
index bf719b2a29..a088f6b61f 100644
--- a/libavfilter/qsvvpp.c
+++ b/libavfilter/qsvvpp.c
@@ -833,7 +833,7 @@ int ff_qsvvpp_filter_frame(QSVVPPContext *s, AVFilterLink *inlink, AVFrame *picr
QSVAsyncFrame aframe;
mfxSyncPoint sync;
QSVFrame *in_frame, *out_frame;
- int ret, filter_ret;
+ int ret, ret1, filter_ret;
while (s->eof && av_fifo_read(s->async_fifo, &aframe, 1) >= 0) {
if (MFXVideoCORE_SyncOperation(s->session, aframe.sync, 1000) < 0)
@@ -890,8 +890,13 @@ int ff_qsvvpp_filter_frame(QSVVPPContext *s, AVFilterLink *inlink, AVFrame *picr
av_fifo_read(s->async_fifo, &aframe, 1);
do {
- ret = MFXVideoCORE_SyncOperation(s->session, aframe.sync, 1000);
- } while (ret == MFX_WRN_IN_EXECUTION);
+ ret1 = MFXVideoCORE_SyncOperation(s->session, aframe.sync, 1000);
+ } while (ret1 == MFX_WRN_IN_EXECUTION);
+
+ if (ret1 < 0) {
+ ret = ret1;
+ break;
+ }
filter_ret = s->filter_frame(outlink, aframe.frame->frame);
if (filter_ret < 0) {