aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Niedermayer <michaelni@gmx.at>2014-10-04 00:13:26 +0200
committerMichael Niedermayer <michaelni@gmx.at>2014-10-04 23:52:29 +0200
commit506368f563b80a1b3663d31194171b00fdbf4bed (patch)
treed64a70c248e1d856986193fd22f8e0b65679aa79
parentc0c24bc9b32419c7883a344c74a6779374a3c16a (diff)
downloadffmpeg-506368f563b80a1b3663d31194171b00fdbf4bed.tar.gz
avcodec/svq3: Dont memcpy AVFrame
This avoids out of array accesses Fixes: asan_heap-uaf_21f42e4_9_asan_heap-uaf_21f42e4_278_gl2.mov Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <michaelni@gmx.at> (cherry picked from commit 075a165d2715837d125a9cc714fb430ccf6c9d6b) Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
-rw-r--r--libavcodec/svq3.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/libavcodec/svq3.c b/libavcodec/svq3.c
index 97233b19d6..9459329058 100644
--- a/libavcodec/svq3.c
+++ b/libavcodec/svq3.c
@@ -1176,7 +1176,7 @@ static int svq3_decode_frame(AVCodecContext *avctx, void *data,
h->cur_pic_ptr = s->cur_pic;
av_frame_unref(&h->cur_pic.f);
- h->cur_pic = *s->cur_pic;
+ memcpy(&h->cur_pic.tf, &s->cur_pic->tf, sizeof(h->cur_pic) - offsetof(H264Picture, tf));
ret = av_frame_ref(&h->cur_pic.f, &s->cur_pic->f);
if (ret < 0)
return ret;