aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarvin Scholz <epirat07@gmail.com>2024-08-13 20:06:42 +0200
committerMarvin Scholz <epirat07@gmail.com>2024-09-12 05:11:14 +0200
commit504c1ffcd8dd09c40f4eacecb407d5fce423145c (patch)
tree9663f8ef5a144495bccd01141e37c5e3c57b9cc3
parent2e91532ead860651c135bdedd96b6112ff715529 (diff)
downloadffmpeg-504c1ffcd8dd09c40f4eacecb407d5fce423145c.tar.gz
fftools/ffmpeg: remove useless error check
When ret is checked here, it was never assigned anything, making this check useless, as highlighted by Coverity. It seems to be a copy paste mistake given that opt_match_per_stream_str does not return an error code that could be checked and the previous value assigned to ret is already checked above. So just remove this check. Fixes: CID1616292
-rw-r--r--fftools/ffmpeg_mux_init.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c
index 274bc61689..6e6eda32e7 100644
--- a/fftools/ffmpeg_mux_init.c
+++ b/fftools/ffmpeg_mux_init.c
@@ -1315,8 +1315,6 @@ static int ost_add(Muxer *mux, const OptionsContext *o, enum AVMediaType type,
const char *format = "{fidx} {sidx} {n} {t}";
opt_match_per_stream_str(ost, &o->enc_stats_pre_fmt, oc, st, &format);
- if (ret < 0)
- goto fail;
ret = enc_stats_init(ost, &ost->enc_stats_pre, 1, enc_stats_pre, format);
if (ret < 0)