diff options
| author | Matt Wolenetz <wolenetz@google.com> | 2016-12-14 15:24:42 -0800 |
|---|---|---|
| committer | Michael Niedermayer <michael@niedermayer.cc> | 2017-02-08 04:08:26 +0100 |
| commit | 4f7064c9da35cd8156f6aee4a25e9b4e7f4ae607 (patch) | |
| tree | d137a19a0e71bda1d0bf1a3692081892a327bbcd | |
| parent | bb504aa5eb7eb32dbb62545772285e794af85651 (diff) | |
| download | ffmpeg-4f7064c9da35cd8156f6aee4a25e9b4e7f4ae607.tar.gz | |
lavf/mov.c: Avoid heap allocation wrap in mov_read_hdlr
Core of patch is from paul@paulmehta.com
Reference https://crbug.com/643950
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Check value reduced as the code does not support larger lengths
(cherry picked from commit fd30e4d57fe5841385f845440688505b88c0f4a9)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
| -rw-r--r-- | libavformat/mov.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/libavformat/mov.c b/libavformat/mov.c index 6b90d08ddc..e6b6c67309 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -674,6 +674,8 @@ static int mov_read_hdlr(MOVContext *c, AVIOContext *pb, MOVAtom atom) title_size = atom.size - 24; if (title_size > 0) { + if (title_size > FFMIN(INT_MAX, SIZE_MAX-1)) + return AVERROR_INVALIDDATA; title_str = av_malloc(title_size + 1); /* Add null terminator */ if (!title_str) return AVERROR(ENOMEM); |