diff options
| author | Matt Wolenetz <wolenetz@google.com> | 2018-04-10 13:59:25 -0700 |
|---|---|---|
| committer | Michael Niedermayer <michael@niedermayer.cc> | 2018-10-23 01:44:40 +0200 |
| commit | 4b04da1e52da16f1c56e1532c0e65b1f9771431c (patch) | |
| tree | 193abf16a87f6f660b1ef5685eb5a2889cb7745c | |
| parent | c0bb5613d42f8ed6d661886b5084031387ce0882 (diff) | |
| download | ffmpeg-4b04da1e52da16f1c56e1532c0e65b1f9771431c.tar.gz | |
lavc/libopusdec: Allow avcodec_open2 to call .close
If there is a decoder initialization failure detected in avcodec_open2
after .init is called, allow graceful decoder .close to prevent leaking
libopus decoder allocations.
BUG=828526
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit e43e97f0e0f0596b56ceb2f887fe7414f202f081)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
| -rw-r--r-- | libavcodec/libopusdec.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/libavcodec/libopusdec.c b/libavcodec/libopusdec.c index 7dff9c16b7..f9480fbbb6 100644 --- a/libavcodec/libopusdec.c +++ b/libavcodec/libopusdec.c @@ -126,7 +126,10 @@ static av_cold int libopus_decode_close(AVCodecContext *avc) { struct libopus_context *opus = avc->priv_data; - opus_multistream_decoder_destroy(opus->dec); + if (opus->dec) { + opus_multistream_decoder_destroy(opus->dec); + opus->dec = NULL; + } return 0; } @@ -200,6 +203,7 @@ AVCodec ff_libopus_decoder = { .decode = libopus_decode, .flush = libopus_flush, .capabilities = AV_CODEC_CAP_DR1, + .caps_internal = FF_CODEC_CAP_INIT_CLEANUP, .sample_fmts = (const enum AVSampleFormat[]){ AV_SAMPLE_FMT_FLT, AV_SAMPLE_FMT_S16, AV_SAMPLE_FMT_NONE }, |